
Faster PRs - Lower The Barrier Of Entry
Reviewing pull requests is a pain in the hole, but a necessary one. It is also massive time sync if youâre actually doing it right. Normal PR Process It often looks like this: Get slack message: âpwetty pwease review my PR :3 pr linkâ Open in browser, scroll through the code a bit Inner Monologue: âThis looks mostly understandable? Can I can get away without pulling this locally?â Decide to run it locally Stash current branchâs changes (remember that you have a stash saved!). Pull down PR branch. Run the code/tests (Hopefully it runs). Click through all the changes going back and forth with the PR on github.com. See an issue in the editor and flip to the web browser, find the line, and post a comment in the PR. view it in the browser Attempt to read the code. Optional: Try to âunderstandâ the logic, but often youâre just NITing formatting issues because you canât run it. If you see a glaring issue or have a question, plop a comment in the PR. Yucky DX From a DX perspective, this process is slow and shit. If I think itâs slow and shit, I know my team does as well. If my team thinks itâs slow and shit, then when theyâre stressed or lazy, theyâre not pulling down my code, meaning theyâre not reviewing my PRs well, meaning weâre often committing worse code and bugs into master. ...